Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update MP GraphQL to v15 and peer dependencies [DRAFT / IN-PROGRESS] #5455

Closed
wants to merge 26 commits into from

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Dec 1, 2023

This PR updates MP GraphQL to v15 and all required dependencies to the first version that supports that.

As I started upgrading packages, I had some troubles with enums and had to reapply patches we made. Eventually, I was happy to see that the graphql-tools v15 does the same as we do in our patch and there was no need for the patch anymore.

What comes next after this?
graphql 15 and express-graphql both have experimental @defer and stream branches. I am planning on evaluating the effort for such an integration later

@MounirDhahri
Copy link
Member Author

MounirDhahri commented Dec 1, 2023

I will remove reviewers until I fix the broken tests
I will keep the PR open in order for tests to run

@MounirDhahri MounirDhahri marked this pull request as ready for review December 1, 2023 14:42
@MounirDhahri MounirDhahri changed the title feat: update MP GraphQL to v15 and peer dependencies feat: update MP GraphQL to v15 and peer dependencies [DRAFT / IN-PROGRESS] Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant