-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update MP GraphQL to v15 and peer dependencies [DRAFT / IN-PROGRESS] #5455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
requested review from
joeyAghion,
dzucconi,
dblandin,
damassi and
mzikherman
December 1, 2023 14:23
I will remove reviewers until I fix the broken tests |
MounirDhahri
removed request for
joeyAghion,
dzucconi,
dblandin,
damassi and
mzikherman
December 1, 2023 14:26
MounirDhahri
changed the title
feat: update MP GraphQL to v15 and peer dependencies
feat: update MP GraphQL to v15 and peer dependencies [DRAFT / IN-PROGRESS]
Dec 6, 2023
(cherry picked from commit 34f3b527fd731ceabeb59b53a3b3610d67b62679)
(cherry picked from commit 9194bde119ad00fc1762c66e59db9ca578f7e9cc)
This reverts commit b6eb6ed7cb6e73707694faa21278cc5708fec016.
This reverts commit 2333c383ad81b08e99e00f1ff74c17c4ec0dc853.
MounirDhahri
force-pushed
the
feat/upgrade-mp-deps
branch
from
December 14, 2023 08:59
7c489de
to
b78dc99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates MP GraphQL to v15 and all required dependencies to the first version that supports that.
As I started upgrading packages, I had some troubles with enums and had to reapply patches we made. Eventually, I was happy to see that the
graphql-tools
v15 does the same as we do in our patch and there was no need for the patch anymore.What comes next after this?
graphql
15 andexpress-graphql
both have experimental@defer
andstream
branches. I am planning on evaluating the effort for such an integration later